India_NationalAccountsStatistics configs#1863
India_NationalAccountsStatistics configs#1863saanikaaa wants to merge 3 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @saanikaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the dataset for India's economic statistics by adding comprehensive configuration files for National Accounts data from MOSPI. It enables the ingestion of detailed information on GDP, GSDP, and GVA, broken down by various estimates, price types, and economic sectors, as well as by state for GSDP. This enhancement will provide a richer foundation for economic analysis and data visualization related to India. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR adds configuration files for importing India's National Accounts Statistics. The changes look mostly good, but there are a few issues to address. There's a typo in the filenames for GVA_FristAdvanceEstimates (Frist should be First). More importantly, there are several data correctness issues in the pvmap files, including incorrect Wikidata IDs for some places, a copy-paste error in a key, and an invalid value """"" used in multiple GVA pvmap files which will likely cause processing errors.
No description provided.